Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/86 make token configurable via new secret GITHUB_USER_TOKEN #87

Merged
merged 22 commits into from
Nov 28, 2023

Conversation

luislard
Copy link
Contributor

@luislard luislard commented Nov 2, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Closes #86

Makes the token configurable so consumers are able to use specific user tokens to for example bypass some branch protection rules.

What is the current behavior? (You can also link to an open issue here)
Token is not configurable

What is the new behavior (if this is a feature change)?
The used token is configurable

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:

@luislard luislard changed the title Feat/86 make token configurable Feat/86 make token configurable via new secret USER_TOKEN Nov 3, 2023
Copy link
Contributor

@dottxado dottxado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @luislard ! Please update the docs here 💪

.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
@luislard luislard requested a review from dottxado November 8, 2023 08:55
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I left a couple of comments. Also, I'm not a big fan of the USER_TOKEN naming; what about WRITE_TOKEN or similar?

.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
.github/workflows/automatic-release.yml Show resolved Hide resolved
docs/automatic-release.md Outdated Show resolved Hide resolved
docs/automatic-release.md Outdated Show resolved Hide resolved
luislard and others added 3 commits November 8, 2023 14:54
.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
.github/workflows/automatic-release.yml Outdated Show resolved Hide resolved
docs/automatic-release.md Outdated Show resolved Hide resolved
@luislard luislard changed the title Feat/86 make token configurable via new secret USER_TOKEN Feat/86 make token configurable via new secret GITHUB_USER_TOKEN Nov 14, 2023
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one last minor suggestion. Apart from that LGTM. Thanks for working on this! 🙏🏽

docs/automatic-release.md Outdated Show resolved Hide resolved
Co-authored-by: Philipp Bammes <[email protected]>
Signed-off-by: Christian Leucht <[email protected]>
Copy link
Member

@Chrico Chrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍🏻

@Chrico Chrico merged commit 7efcca8 into main Nov 28, 2023
@Chrico Chrico deleted the feat/86_make_token_configurable branch November 28, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants