-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(outputs.azure_data_explorer): Add AppName in connector details #16102
base: master
Are you sure you want to change the base?
Conversation
feat: ConnectorName added to ADX props
@asaharn it seems to me as if the |
Hi @srebhan, the AppName is restricted to be only accessible internally at telegraf plugin level. This will help us in monitoring the usage telemetry, to differentiate between usage of ADX output plugin. 1) Native Output plugin i.e. "Kusto.Telegraf" or 2) Microsoft Fabric output plugin, i.e. "Fabric.Telegraf" (an upcoming output plugin) Please note that we will raise the PR for MS Fabric right after this PR gets merged as the changes are ready. |
Hello @srebhan , a gentle ping. Please let us know if there are any required changes. We have another feature that is blocked due to this PR. |
Sorry but this does not make sense. Why do you add an exported field to a struct that should be used solely internally? Why not just using the string a the SINGLE usage point then? |
Hi @srebhan, |
Hi @srebhan . I think I was able to explain my point. And we welcome suggestions regarding this. |
@asaharn I see your point in the code you linked. Please note you cannot import a plugin in another plugin! That's something we don't want as it is impossible to maintain. Therefore, the correct move would be to move the code common to both plugins into Does that make sense? |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
@asaharn any comment on moving the common part to |
Hi @srebhan, thank you for the suggestion. yes, we are looking for the feasibility to move code for both the connectors to |
Summary
Adding App name will help to identify the source plugin of incoming telemetry data eg. Kusto or Microsoft Fabric (upcoming plugin by Microsoft).
Checklist
Related issues
resolves #16101