This repository has been archived by the owner on May 25, 2023. It is now read-only.
Implement IPSet.Invert and IPSet.Intersect. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danderson
force-pushed
the
danderson/set-intersection
branch
from
d03d0ad to
487778c
Compare
josharian
reviewed
Jan 28, 2021
| s.out = s.in | ||
| s.in = []IPRange{ | ||
| IPPrefix{IP: IPv4(0, 0, 0, 0), Bits: 0}.Range(), | ||
| IPPrefix{IP: IPv6Unspecified(), Bits: 0}.Range(), |
There was a problem hiding this comment.
Should we iterate through the s.in, discover all IPv6 zones contained therein, and add those here? Should we have IPv6 at all if s.in only contains IPv4?
Either way, we should document what universe we're taking the complement in.
There was a problem hiding this comment.
Hmmm. IPSet doesn't really deal with zones at all right now (e.g. compaction will smush together IPs across zones), so I think I'm going to turn this into a bug to figure out what to do, and we can fix all of IPSet at once. Until then, leaving as-is.
danderson
force-pushed
the
danderson/set-intersection
branch
from
487778c to
e9210e4
Compare
danderson
force-pushed
the
danderson/bug-demo
branch
from
3ffd647 to
b265e07
Compare
danderson
force-pushed
the
danderson/set-intersection
branch
from
e9210e4 to
525d3c7
Compare
Fixes #123. Signed-off-by: David Anderson <[email protected]>
danderson
force-pushed
the
danderson/set-intersection
branch
from
525d3c7 to
4e1358f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123.
Signed-off-by: David Anderson [email protected]
I set the merge-base to #124 so it shows only the new functionality.