This repository has been archived by the owner on May 25, 2023. It is now read-only.
De-emphasize IPv4-mapped IPv6 handling, relegate it to stdlib compat. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #64. Signed-off-by: David Anderson <[email protected]>
bradfitz
reviewed
Dec 31, 2020
| // address. | ||
| func IPv6Raw(addr [16]byte) IP { | ||
| // IPFrom16 returns the IPv6 address given by the bytes in addr. | ||
| func IPFrom16(addr [16]byte) IP { |
There was a problem hiding this comment.
This violates the "new behavior, new name" adage. It's better to break existing callers than silently break them with a change in behavior.
If this will only return IPv6 now, maybe a better name is just IPv6 to match https://godoc.org/inet.af/netaddr#IPv4.
bradfitz
reviewed
Dec 31, 2020
| @@ -1289,6 +1280,10 @@ func (u uint128) or(m uint128) uint128 { | |||
| return uint128{u.hi | m.hi, u.lo | m.lo} | |||
| } | |||
|
|
|||
| func (u uint128) not() uint128 { | |||
There was a problem hiding this comment.
the other three above have docs, even if internal
bradfitz
reviewed
Dec 31, 2020
| }, | ||
| { | ||
| name: "4in6-unmap", | ||
| fn: FromStdIP, | ||
| std: net.ParseIP("1.2.3.4"), | ||
| std: net.ParseIP("1.2.3.4").To16(), |
There was a problem hiding this comment.
this change shouldn't be doing anything, right? I'd prefer you keep the old line alone and add a second test, even if it's currently redundant. It'd be interesting if it one of the cases failed in a future Go release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal implementation for #64, to de-emphasize auto-unmapping. Keep it for stdlib because stdlib makes ambiguous types, but otherwise constructors don't do unobvious things.