Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables toggle behaviour like Bootstrap accordion #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

julianalucena
Copy link

Hides selected panel when the user clicks on it again, like Bootstrap accordion behaviour (closes #3):

ezgif com-video-to-gif 2

Also, I fixed a strange behaviour: accordion select function was called twice when the panel was clicked by the user. You can see this through the console:

ezgif com-video-to-gif 1

@david-duncan
Copy link

I built on top of your PR in #5 and removed the click handler from the component itself and placed it as an action in the component. This prevents certain contents of the accordion panel from toggling the collapse of the accordion, and ensures the intended behavior of the accordion collapsing can only be toggled from inside of the accordion header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support de-selecting of already-selected panel, so that all panels may be closed
2 participants