HTTPie Auth Store #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalnytskyi
force-pushed
the
feat/auth-store
branch
2 times, most recently
from
911f23a to
1b76eec
Compare
Apparently CI has been completely broken I don't know how long due to pipx using the python interpreter it was installed for, instead of using the one we specifically prepared for tests. This patch uses python3 alias to install tox and run tests, which must guarantee proper python interpreter.
The auth store seems to more correctly reflect what is this plugin about. Taking into account that I plan to introduce a bunch of changes w/o preserving backward compatibility, it sounds like a good idea to publish a new version under a new name. This patch also drops deprecated 'creds' and 'credential-store' auth types because the plan is to introduce backward incompatible changes anyway.
First version of the auth store lacked two major features: (1) it was
impossible to share secrets between auth bindings, and (2) it was
impossible to define an auth binding to many resources (URLs)
simultaneously. In addition to that, it contained a bunch of nested
blocks which were hard to write and mantain.
New, second version of the auth store is designed to address those
concerns by (1) separating secrets from auth bindings, (2) reducing
nesting level, and (3) supporting multiple resources (URLs) per auth
binding.
{
"bindings": [
{
"auth_type": "bearer",
"auth": "$GITHUB_TOKEN",
"resources": ["https://api.github.com/"]
}
],
"secrets": {
"GITHUB_TOKEN": {
"provider": "system",
"service": "github.com",
"username": "ikalnytskyi"
}
}
}
This patch also delivers a significant internal refactoring. The most
notable change is that "types" are enforced internally instead of
dealing with dictionaries around. I don't think performance is going to
be an issue here. :)
The plugin is changed significantly and even changed its name. It's about time to reflect that in the README file. The conversion to Markdown just happened along the way because Markdown is a more popular choice, and because GitHub's Markdown flavour goes a long way to improve original syntax.
In order to ease managing of auth entries and give some examples to end users, instead of asking them to create the auth store themselves, we better create one automatically.
ikalnytskyi
force-pushed
the
feat/auth-store
branch
from
c2715a7 to
b7d6b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.