Add third-party auth plugins support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTPie ecosystem has myriads of third-party authentication plugins. Even though they ain't as widespread as core ones, I see a huge advantage if we can support those plugins too. This patch adds support of third-party authentication plugins by retrieving a proper authentication plugin via HTTPie's plugin manager, instead of reimplementing authentication code for core plugins in this project source tree. There's another benefits of using authentication plugins here. According to some HTTPie in-source comments, the HTTP basic auth from requests library has some unicode issues, and those HTTPie mantains its own basic auth implementation. By using authentication plugins directly, we can get advantage of that implementation too.
ikalnytskyi
force-pushed
the
feat/support-auth-plugins
branch
from
23df99d to
60d889b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTPie ecosystem has myriads of third-party authentication plugins. Even though they ain't as widespread as core ones, I see a huge advantage if we can support those plugins too.
This patch adds support of third-party authentication plugins by retrieving a proper authentication plugin via HTTPie's plugin manager, instead of reimplementing authentication code for core plugins in this project source tree.
There's another benefits of using authentication plugins here. According to some HTTPie in-source comments, the HTTP basic auth from requests library has some unicode issues, and those HTTPie mantains its own basic auth implementation. By using authentication plugins directly, we can get advantage of that implementation too.