Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move user-based path setting out of Config object #32

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

measrainsey
Copy link
Contributor

@measrainsey measrainsey commented Oct 22, 2024

This PR changes where and how the user-based paths for data is set.

Previously, this was done within the Config object, but with this PR it will be done in a function outside of the Config object. This PR should address #31

There is also a small change to save a file in postprocessing, which was done as part of #34, then merged into this branch

This branch is based off of chilled/input-files, which is associated with the PR #29

@measrainsey measrainsey added bug Something isn't working chilled PRs and issues related to the CHILLED model labels Oct 22, 2024
@measrainsey measrainsey self-assigned this Oct 22, 2024
@measrainsey measrainsey marked this pull request as ready for review October 22, 2024 15:00
Currently data is stored in a folder that has a version number on it. It would be better to remove this so the files being read won't be dependent on this numbering system but instead should only depend on version name.
@measrainsey measrainsey changed the base branch from main to chilled/input-files October 22, 2024 15:05
@measrainsey measrainsey merged commit 6e173c7 into chilled/input-files Oct 31, 2024
@measrainsey measrainsey deleted the chilled/upd-paths branch October 31, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chilled PRs and issues related to the CHILLED model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default user setting in CHILLED is passed over even if selected user is different
1 participant