feat: Add idnits3 for post submission nits check button #8169
Conversation
| @@ -2996,6 +2996,24 @@ def test_raw_id(self): | |||
| self.should_succeed(dict(name=draft.name, rev='00',ext='txt')) | |||
| self.should_404(dict(name=draft.name, rev='00',ext='html')) | |||
|
|
|||
| @override_settings(IDNITS3_BASE_URL="https://example.org/idnits3") | |||
| def test_nits_url(self): | |||
| draft = WgDraftFactory(name="draft-ietf-moon-test",rev="01", create_revisions=range(0,2)) | |||
There was a problem hiding this comment.
A comment as to why you're setting up this particular arrangement of revisions would be helpful
|
If someone really wanted the v2 nits, can they get back to them quickly? |
|
Nudge:
|
No there are no quick links for that. Author tools just shows the output from idnits. |
|
so maybe instead of replacing the idnits2 button, we provide both idnits2 and idnits3 buttons until idnits3 becomes the thing in the submit path? |
|
Where can I find idnits3? |
@cabo, You can install with Footnotes |
One of the motivations of this change is to stop unnecessary idnits2 checks because this makes a call to datatracker which seems slow and could affect datatracker performance. |
OK, I have that, so "3.0.0-alpha.36" appears to be the most recent revision. https://author-tools.ietf.org/api/idnits3?url=https://www.ietf.org/archive/id/draft-ietf-cbor-cddl-more-control-07.xml |
@cabo, idnits v3 is still in alpha stage of development. But you can report any issues to idnits repository1 so we can correct them early. Footnotes |
kesara
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8169 +/- ##
==========================================
+ Coverage 88.78% 88.94% +0.16%
==========================================
Files 296 303 +7
Lines 41320 41288 -32
==========================================
+ Hits 36687 36725 +38
+ Misses 4633 4563 -70 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
We need to signal that this is a new, not yet complete, and under development tool. Maybe we can use a tooltip, but there are accessibility concerns with that. Maybe we should put it on its own row with explanatory text? Other ideas? |
This change adds a new Nits 3 button in addition to the existing Nits button.
Fixes #8107