Merge pull request #27 from iamed2/ale/specializations

 avoid specializing convert for Any result types (superseding #25)

Project.toml

@@ -1,7 +1,7 @@
 name = "ResultTypes"
 uuid = "08a2b407-ddc3-586a-afd6-c784ad1fffe2"
 authors = ["Eric Davies"]
-version = "3.1.0"
+version = "3.2.0"
 
 [compat]
 julia = "1"

src/ResultTypes.jl

@@ -113,10 +113,18 @@ function Base.convert(::Type{Result{S, E}}, r::Result) where {S, E <: Exception}
     return promote_type(Result{S, E}, typeof(r))(r.result, r.error)
 end
 
+function Base.convert(::Type{Result{Any, E}}, r::Result) where {E <: Exception}
+    return promote_type(Result{Any, E}, typeof(r))(r.result, r.error)
+end
+
 function Base.convert(::Type{Result{S, E}}, x::T) where {T, S, E <: Exception}
     return Result{S, E}(Some(convert(S, x)), nothing)
 end
 
+function Base.convert(::Type{Result{Any, E}}, @nospecialize(x)) where {E <: Exception}
+    return Result{Any, E}(Some{Any}(x), nothing)
+end
+
 function Base.convert(::Type{Result{T, E}}, e::E) where {T, E <: Exception}
     return Result{T, E}(nothing, e)
 end
@@ -125,6 +133,10 @@ function Base.convert(::Type{Result{T, E}}, e::E2) where {T, E <: Exception, E2
     return Result{T,E}(nothing, convert(E, e))
 end
 
+function Base.convert(::Type{Result{Any, E}}, e::E2) where {E <: Exception, E2 <: Exception}
+    return Result{Any,E}(nothing, convert(E, e))
+end
+
 function Base.show(io::IO, r::Result{T, E}) where {T, E <: Exception}
     if iserror(r)
         print(io, "ErrorResult(", T, ", ", unwrap_error(r), ")")

test/runtests.jl

@@ -146,6 +146,18 @@ end
 
         @test isempty(ambs)
     end
+
+    @testset "Specializations" begin
+        AnyRes = Result{Any, Exception}
+        struct MyT end
+
+        convert(AnyRes, MyT())
+        method = only(methods(convert, Tuple{Type{AnyRes}, MyT}))
+        specs = method.specializations
+        specs_v = method.specializations isa Core.MethodInstance ? [specs] : collect(method.specializations)
+        @test only(filter(!isnothing, specs_v)).specTypes ==
+              Tuple{typeof(convert), Type{AnyRes}, Any}
+      end    
 end
 
 @testset "Return" begin