This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Upgrade to node 18 #1779
Merged
Upgrade to node 18 #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @ifixit/commerce-frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
federicobadini
force-pushed
the
upgrade-to-node-18
branch
from
5e7f02a to
e4cde13
Compare
|
All looks well. QA 😺 |
masonmcelvain
approved these changes
Jul 5, 2023
|
This continue to look good. QA 😺 |
deploy_block 🛑 I think deploy blocks in the pull description don't register. |
|
un_deploy_block 👍 Looks like react-commerce-prod is already at node 18.
Also, the strapi docker image is built and deployed with every relevant merge, so no manual work is needed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1756
This PR addresses and closes issue #1756 by standardizing Node.JS to v18 for all environments (development, preview, and production). The upgrade extends to both the frontend and Strapi.
Frontend
We compensated for a change brought in by Node.js 17 that deprioritized ipv4 addresses over ipv6 by introducing the env variable --dns-result-order ipv4first across various commands; see here. Node.JS 17 made this change without introducing a happy-eyeballs implementation, which led to addresses often resolving to the ipv6 loopback address ::1 instead of 127.0.0.1, thus breaking builds. Notably, Node 20 included a happy-eyeballs implementation, and we anticipate being able to remove these env variables in the future.
Strapi
Our current version of Strapi advises the use of Node 18 as per their documentation here. To reflect this, we have updated the backend's package.json to only permit the use of the advised Node.JS versions ("node": ">=14.x.x <=18.x.x") and we updated the Strapi docker base image.
QA
Node.JS 18 is already set as the build image for the react-commerce Vercel project. Please note that react-commerce-prod will also be updated just before this PR is deployed.
So deploy_block 🛑 for the above reason.