Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-pin upload-artifact action and enable include-hidden-files option for coverage upload #8929

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

robertknight
Copy link
Member

This resolves an issue where the .coverage.{python_version} file was not uploaded.

See actions/upload-artifact#602 and https://hypothes-is.slack.com/archives/C4K6M7P5E/p1725285976308269.

Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coverage step fails here as well 😅. We'll have to merge with a red CI.

@robertknight
Copy link
Member Author

Hmm, this didn't work.

@robertknight robertknight force-pushed the fix-coverage-upload branch 2 times, most recently from 10041e5 to 093db4f Compare September 2, 2024 16:31
The `include-hidden-files` setting is required in future releases of this action
to enable uploading files whose names begin with a period.  We pinned the action
previously because this config option was broken when initially added, but it
has now been fixed.

See https://github.com/actions/upload-artifact/releases/tag/v3.2.1-node20.
@robertknight robertknight changed the title Enable include-hidden-files option for coverage upload Un-ping upload-artifact action and enable include-hidden-files option for coverage upload Sep 3, 2024
@robertknight robertknight changed the title Un-ping upload-artifact action and enable include-hidden-files option for coverage upload Un-pin upload-artifact action and enable include-hidden-files option for coverage upload Sep 3, 2024
@robertknight
Copy link
Member Author

The upstream issue with include-hidden-files: true has now been resolved.

@robertknight robertknight merged commit 7b688c9 into main Sep 3, 2024
9 checks passed
@robertknight robertknight deleted the fix-coverage-upload branch September 3, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants