Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPT-3G export tune up #588

Open
wants to merge 11 commits into
base: toast3
Choose a base branch
from

Conversation

cnweaver
Copy link

This set of changes encompasses my fixes to make data exported by TOAST readable by spt3g_software to a point such that a skymap can be produced from simulated detector data. As my focus was on the export case, some new functionality isn't mirrored for importing, although some of the more fundamental parts are.

The main changes are:

  • Exporting focal plane geometry using SPT-3G datastructures
  • Setting units on the detector data and correcting how units are translated
  • Accounting for a coordinate system convention difference when translating directions
  • Splitting data into G3Frames in a manner more typical for experimental data

There is also some optimization of IntervalList intersections, as this was a bottleneck for exporting data.

@tskisner
Copy link
Member

Thanks @cnweaver , will check this out soon.

@cnweaver
Copy link
Author

Hm, it looks like there might be something fishy about the change in b1a3e6c. I'll look into it as soon as I can.

@tskisner
Copy link
Member

Just a note, I am working on a PR that systematically enforces consistent units for timestreams across all simulation operators, noise estimation, etc. Should only impact a few lines of this PR, but wanted to give you a heads up.

@cnweaver
Copy link
Author

Okay, I'll be happy to rebase/sync merge/whatever to work with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants