-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for templated components #8
base: main
Are you sure you want to change the base?
Conversation
The API key to use to authenticate with Honeycomb. | ||
type: string | ||
validations: [nonblank] | ||
default: ${HONEYCOMB_TRACES_APIKEY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default: ${HONEYCOMB_TRACES_APIKEY} | |
default: ${HONEYCOMB_API_KEY} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was deliberate to avoid confusion with API keys you may be using for other purposes; it's not a world where one honeycomb key makes sense anymore. I think it's likely that you'll have multiple Honeycomb keys, so I've changed the name to make it even clearer.
@@ -0,0 +1,35 @@ | |||
name: ToHoneycomb | |||
kind: HoneycombExporter | |||
summary: Export traces to Honeycomb in Honeycomb's event format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
summary: Export traces to Honeycomb in Honeycomb's event format | |
summary: Export telemetry to Honeycomb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my suggestion here is that this component could be generic enough to emit any kind of data to honeycomb, the export format might not be necessary to call out in the documentation of the component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component today only applies to Refinery, but it's a good point that logs can also flow through Refinery. So I changed it to telemetry but left in the "event format" part.
Which problem is this PR solving?
Short description of the changes