Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-ins #7

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add check-ins #7

wants to merge 5 commits into from

Conversation

stympy
Copy link
Member

@stympy stympy commented Dec 17, 2024

No description provided.

Copy link

Check-in command

@stympy stympy requested a review from a team December 18, 2024 13:04
Copy link

@rabidpraxis rabidpraxis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking good. I have some other thoughts:

I'm wondering if the command run is too generic for what it is doing. What if the command was check-in with an optional command separator for reporting external command results? That way they can send a check-in on its own or send the results of a command execution.

I was also wondering if we should we propagate the exit code from the run command?

@stympy
Copy link
Member Author

stympy commented Dec 18, 2024

I'm wondering if the command run is too generic for what it is doing. What if the command was check-in with an optional command separator for reporting external command results? That way they can send a check-in on its own or send the results of a command execution.

Yeah, I think it makes sense to be able to report a check-in without having to run a command, and that check-in would be a better command name for that.

I was also wondering if we should we propagate the exit code from the run command?

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants