Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for smartlife custom integration #5296

Closed
wants to merge 1 commit into from
Closed

Add icon for smartlife custom integration #5296

wants to merge 1 commit into from

Conversation

maxim-102
Copy link

@maxim-102 maxim-102 commented Mar 16, 2024

Add icon smartlife custom integration

Proposed change

Added the icon for the smartlife custom integration

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Add icon smartlife custom integration
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are application icons, not manufacturer icons.

I suggest using the Tuya branding here instead.

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 18, 2024 14:55
@maxim-102 maxim-102 closed this Mar 18, 2024
@KelvinVenancio
Copy link

Hi @maxim-102, why did you close this PR? I'm facing an issue that I think we can fix with that. I did not know if I understood the @frenck suggestion, but was it to put those images in another folder? Thanks.

Captura de Tela 2024-04-03 às 17 18 41

@Diadlo
Copy link

Diadlo commented May 4, 2024

@frenck Hi!

Am I right that you suggested using the Tuya logo instead of the SmartLife application logo? In that case, the integration could be confused with the core Tuya integration, couldn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing smartlife icon
4 participants