Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better async support #17

Closed
wants to merge 6 commits into from
Closed

Better async support #17

wants to merge 6 commits into from

Conversation

dharmaturtle
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Pull Request Test Coverage Report for Build 5431066058

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.13%

Totals Coverage Status
Change from base Build 5406784932: 0.0%
Covered Lines: 197
Relevant Lines: 216

💛 - Coveralls

@JohnEfford
Copy link

This came about when I was trying to document the Property attribute when running async tasks. I was not able to exercise the code in FSharp which is why I added the Hedgehog.Xunit.CSharp.Tests project. Sorry if it has complicated the merge.

@dharmaturtle
Copy link
Member Author

dharmaturtle commented Jul 1, 2023

All good! This draft PR exists because I was sanity checking my ? commit which undos some of your changes - I was trying to figure out why the tests were passing on my machine, and I wanted to see what CICD thought. Eventually I figured out it was due to Task.CompletedTask; switching them to Task.Delay caused the tests to fail, which is what I wanted. I'm guessing the former gets JITed to be synchronous or something; IDK my async knowledge is poor. The failing tests (which is what I wanted) are visible in the most recent commit of the real PR. Closing this because it served its purpose :)

@dharmaturtle dharmaturtle deleted the betterAsyncSupport branch July 1, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants