fix: Fix for #428 unable to run project locally #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamGaash
reviewed
Jan 23, 2024
There was a problem hiding this comment.
seems like this issue is related.
did you try upgrading vite instead?
if that's the only solution, lets take it
NoamGaash
approved these changes
Jan 23, 2024
shootermv
reviewed
Jan 23, 2024
| @@ -82,6 +82,8 @@ | |||
| "@storybook/react": "^7.5.3", | |||
| "@storybook/react-vite": "^7.5.3", | |||
| "@storybook/testing-library": "^0.2.2", | |||
There was a problem hiding this comment.
may we better move to use @vitejs/plugin-react ?
(i think it is better to have as less dependencies as we can, to be dependent on)
VSciFlight
added a commit
to VSciFlight/open-bus-map-search
that referenced
this pull request
Jan 30, 2024
* 'main' of https://github.com/VSciFlight/open-bus-map-search: (94 commits) chore: lint css (hasadna#442) style: Ensure minimum width for ArrivalByTimeChart (hasadna#433) fix: Remove unknown data (hasadna#438) chore: Revert "chore: add temporary route for the version release event (hasadna#382)" (hasadna#441) ci: upgrade linter (hasadna#439) fix: scrollbar color on dark mode (hasadna#431) fix: Fix for issue hasadna#428 unable to run project locally (hasadna#430) chore: Adding tnufa to dropdown in dashboard hasadna#423 (hasadna#429) chore(main): release 1.0.0 (hasadna#326) fix: make input labels visible at dark mode (hasadna#424) fix: make top input label visible at singleLine page (hasadna#420) chore: add i18n type safety (hasadna#419) feat: add home-page files and temp route (hasadna#403) feat: finish bug report form creation (hasadna#411) feat: Translation of the remaining untranslated text on the About page (hasadna#399) test: add SinglelinePage tests (hasadna#393) feat: made logo white on dark mode (hasadna#397) feat: date picker component show invalid dates warning (hasadna#398) chore: hide bug report form (hasadna#388) docs: fixed a dead link in README.md (hasadna#396) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
was not able to run the project locally, I added this devDependencies "@swc/cli" and "swc/core" and it worked