Added a 4 second delay per download due to rate-limiting #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a bit of a hack - there should probably be a configurable delay parameter.
nicholascc
changed the title
|
There should also be a delay when fetching snapshot pages (i.e. get_all_snapshots_to_consider). This seems also to be affected by the rate-limiting. |
This was referenced Nov 16, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264 (15 requests per minute rate-limit by archive.org) by adding a 4-second delay between every download. This is currently a bit of a hack - there should probably be a configurable delay parameter. I'm not good enough at Ruby to implement this in its best form, so someone else should add features like that in another pull request if they want to.
Still, since this library is currently non-functional due to the rate limit, we should just fix it in the simplest way possible right now - by merging this pull request.