Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: make request info available to plugins #579

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

buffrr
Copy link
Contributor

@buffrr buffrr commented Mar 20, 2021

Making the request info available to plugins can be very useful. For example, to do access control based on IP address (bind has this feature). Also, Implementing some advanced features in DNS that requires knowing the protocol, port and IP address like the HSD AXFR plugin which needs rinfo to send multiple dns messages over TCP.

@coveralls
Copy link

coveralls commented Mar 20, 2021

Pull Request Test Coverage Report for Build 670218928

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 59.575%

Totals Coverage Status
Change from base Build 661852759: 0.007%
Covered Lines: 19626
Relevant Lines: 30672

💛 - Coveralls

Copy link
Member

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 50001e2

Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK 50001e2e0b1eee7c02c52bb213d80b403c319f5f
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmBYvh4ACgkQ5+KYS2KJ
yTo0dA//a/J9nHj6nnK88WIp3vHysqz0/fxxUq7aIGyywVzQ6dNJVbiDI3GNysgf
0z28B8eKGX/8/HSP3vfGGPRqFZK1Sh6fgDWby60acMwzIC3EUxy/ivhRCXDT9IDy
lUPWBK4JPJ4RDtiPDj0/n18kckVSAl2eWM54zXMiZiB6lFo8W9HPjIDDIj/ICVjV
XLVSz0eMdFLrEVX3Y/N4aX1NhMmnlrK/UHGyUHooIYsRYtyrTQhRs9U38Cp59INf
ZO9Fzic76F6diuA/xEvULUrmC2aIPR3OzOLTrUmWoaP/7yf72ErENvLEQIj+Ddl+
8OOWfQ8Du7hClyO40vE/79geC/BE9sjCRJniKh+hqbosbvAKjLyFl3ZSX+ghkewN
w6pcEXHAC+P/3DO7N+tsb4YjWUb4nXGRwRZYPi9AZ3/bMa4B8tBWyavYO5dCWQY1
A9vkq8DCU5UY9TUY3Ln3hctzbk3DOl0HkoWX9pgh49ArCYIKSbU5BXAjk72s+qH3
/5PIOqCUDxw3b5WF9D9QN5zLEgbtls1w3djbHDwjkvaaATpxKu7PESSFRLiuGKX3
dkDhKrs7oqlv74ob15duCKaumNZBBeLJd7qhGPFxewCgohSvi/hNBxAvkX+mgwJi
ApJTcPokrHcud5oqCr9e+0dKHP5410K6G7aEpebN+n/5IULD6PU=
=nLoo
-----END PGP SIGNATURE-----

pinheadmz's public key is on keybase

@pinheadmz pinheadmz merged commit 33be3ad into handshake-org:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants