Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor conf page #1877

Open
wants to merge 4 commits into
base: source
Choose a base branch
from
Open

refactor conf page #1877

wants to merge 4 commits into from

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Dec 18, 2024

Summary

Trying to cleanup and bring structure to #1840.

  • App directory lets us have components co-located so create a dedicated components for section (where it makes sense)
  • The container style was applied to every section so let the page layout handles it.
  • Each section was defining its own y gap. Refactored so the main page applies to ensure consistency.
  • Use named exports. I will introduce linting rules in a different PR.
  • Refactors the code for Past Sponsors. To add a new tier simply add a new section to one object and it will work.
  • We just need page level font to apply, no need for each section to import next/font to apply the same font.
  • Page level apply text-white instead of each section apply it.
  • Remove unnecessary props.
  • For prop type definitions no need to create a new interface in components. We are just internally using, this pattern makes sense if we were to create a component library and let others customize things or we were to share some types (which wasn't case for most of those)
  • Remove the FC<> type, find it unnecessary.

@saihaj saihaj requested a review from dimaMachina December 18, 2024 17:59
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:12pm

@saihaj saihaj changed the title saihaj/refactor refactor conf page Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant