Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove globalThis check and align with what bundlers can accept #4022

Merged
merged 8 commits into from
May 29, 2024
Merged

fix: remove globalThis check and align with what bundlers can accept #4022

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
546c13f
remove globalThis process env check
JoviDeCroock Feb 14, 2024
b0ca7e0
add eslint ignore as there was before
JoviDeCroock Feb 14, 2024
cbb05cf
Update src/jsutils/instanceOf.ts
JoviDeCroock May 4, 2024
0b8e107
remove unused directive
JoviDeCroock May 11, 2024
157490b
update check to use globalThis.process
JoviDeCroock May 29, 2024
5b3f00e
add docs
JoviDeCroock May 29, 2024
6b6d7d3
run prettier
JoviDeCroock May 29, 2024
f57c710
add spelling checks
JoviDeCroock May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/jsutils/instanceOf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
import { inspect } from './inspect';

/* c8 ignore next 4 */
const isProduction =
// eslint-disable-next-line no-undef
typeof process !== 'undefined' &&
// eslint-disable-next-line no-undef
process.env &&
// eslint-disable-next-line no-undef
process.env.NODE_ENV === 'production';
JoviDeCroock marked this conversation as resolved.
Show resolved Hide resolved

JoviDeCroock marked this conversation as resolved.
Show resolved Hide resolved
/**
* A replacement for instanceof which includes an error warning when multi-realm
* constructors are detected.
Expand All @@ -9,7 +18,7 @@ import { inspect } from './inspect';
export const instanceOf: (value: unknown, constructor: Constructor) => boolean =
/* c8 ignore next 6 */
// FIXME: https://github.com/graphql/graphql-js/issues/2317
globalThis.process && globalThis.process.env.NODE_ENV === 'production'
isProduction
JoviDeCroock marked this conversation as resolved.
Show resolved Hide resolved
? function instanceOf(value: unknown, constructor: Constructor): boolean {
return value instanceof constructor;
}
Expand Down