Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: support compilation from tarball [PoC, don't merge] #156

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

smarr
Copy link
Collaborator

@smarr smarr commented Jul 21, 2018

This is more of a feature request than a PR.

I'd like to be able to build Graal from a source tarball for the use in artifacts.
The attached patch introduces a stub for a VC in mx, that does achieve that.

However, it's not a general solution, because the suite structure is somewhat hard coded.

Nonetheless, it supports the following use case:

cd graal-jvmci-8
mx clean
mx build
export JAVA_HOME=`../mx/mx jdkhome`
cd ..

cd graal/compiler
export JVMCI_VERSION_CHECK=ignore
mx clean
mx build
mx makegraaljdk $OUT/graal-core

If this is something that would be generally useful, any idea how this could be realized less hacky?

Thanks!

@smarr smarr force-pushed the tar-compile-poc branch 3 times, most recently from aa11839 to 1c87385 Compare July 23, 2018 23:42
@gilles-duboscq
Copy link
Member

Something like that would be useful.
In principle mx should support the case where the vc and vc_dir fields of the Suite are None.
I'm not sure what's easier though: make an artificial VC or fix the code that accesses vc and vc_dir.

As you note in your commit, there needs to be some meta-data in the suite.py file to figure out at what depth the root of the "repo" is.

@smarr smarr force-pushed the tar-compile-poc branch 2 times, most recently from 506ea17 to b88cbbb Compare September 1, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants