-
Notifications
You must be signed in to change notification settings - Fork 17
GUB updates expat/libpng/pixman/cairo/lilypond #86
base: master
Are you sure you want to change the base?
Conversation
Old download link is gone, old version was insecure. Signed-off-by: Knut Petersen <[email protected]>
Update Cairo and Pixman to the newest stable versions, update libpng to newest 1.2.x version. Signed-off-by: Knut Petersen <[email protected]>
Signed-off-by: Knut Petersen <[email protected]>
I'm against adding the dependency from |
Well, since this discussion was not entirely unpredictable, I have already split the pull request code into three patches. I don't expect a big discussion about the expat patch. By the way, the previously used version is still available, they just renamed it to expat-2.1.0-RENAMED-VULNERABLE-PLEASE-USE-2.3.0-INSTEAD.tar.gz. However, the same thing happened with version 2.3.0, so the only thing left to do was to update to 2.4.1. The patch for the spec files of Libpng/Pixman/Cairo means a significant improvement of the graphics stack available in GUB. It think it could be accepted even if the Lilypond developer community decides against the integration of a Cairo backend. Basically, the patch for the Lilypond spec file has the following effects: 1: Bootstrapping of GUB takes a bit longer since the three packages have to be compiled for the four architectures we support. 2: If a version of Lilypond is built that does not use or require LibPng/Pixman/Cairo, the patch does not change anything in the built Lilypond package. The patch only has an effect if a Lilypond version is built that can use LibPng/Pixman/Cairo. I don't know if this patch will ever be integrated into Gub. For me, however, it is logical to provide a patch for GUB in addition to a Lilypond patch if the Lilypond patch would otherwise be pointless. |
I'm not against this one.
This is wrong. GUB will gather all dependent libraries into the installer, and that is pointless as long as we don't want to ship it or the patch(es) didn't even land in the repository. |
As I want to use three commits added to cairo on 2021/07/23 and 2021/07/24 I've set this to draft status. |
The lilypond cairo backend will require cairo, but the pdf and the svg backend of cairo were unable to detect write errors. The pdf backend was unable to generate correct internal page links if page was a reference to a page greater than the current page. In the version used here these three bugs have been fixed. Since January 2021 the cairo test suite also depends on glibc. We do not need the test suite, and we don't want it. The easiest fix is a patch as configure does not allow to disable the test suite.
Ready for the lilypond cairo backend ... i leave the draft status unchanged until it is clear that a cairo backend for lilypond will be accepted. |
expat: Download link broken, update to current version recommended because of security issues.
libpng: upstream bugfix
cairo: replace outdated version, needed by new lilypond cairo backend
pixman: replace outdated version, needed by updated cairo
lilypond: update to allow lilypond with cairo backend. With these patches it is possible to build lilypond with and without the new cairo backend.