-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yaml-cpp: initial integration #12853
base: master
Are you sure you want to change the base?
Conversation
initializedd is integrating a new project: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are maintainers on board with this? I remember the project was approached previously: jbeder/yaml-cpp#963
I have not approached the maintainers of yaml-cpp. |
we need maintainer approval that they are happy to receive and fix bugs |
I will open an issue on the yaml-cpp repository and reference this PR. |
Hey, maintainer of yaml-cpp here. As evidenced by my lack of response to your first PR (sorry, @DavidKorczynski!) I don't have a ton of time for this library. I mostly just approve small PRs for bugfixes. I see the concern
I can't commit to fixing all bugs that OSS-Fuzz comes out with, but I can commit to reviewing any PRs that fix those bugs. @initializedd, would you be willing to commit to (at least trying to) fix bugs? |
The caveat here is that the bugs found are following the Google disclosure policy, which means they will be publicised after 90 days if not fixed (and will be made public once they are fixed too if pre the 90 day deadline). |
I am definitely happy to commit to fixing bugs. @DavidKorczynski In that case, I assume I would need to add myself to |
Initial integration support for a popular C++ YAML library.