Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml-cpp: initial integration #12853

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

initializedd
Copy link

Initial integration support for a popular C++ YAML library.

Copy link

initializedd is integrating a new project:
- Main repo: https://github.com/jbeder/yaml-cpp
- Criticality score: 0.61008

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are maintainers on board with this? I remember the project was approached previously: jbeder/yaml-cpp#963

@initializedd
Copy link
Author

Are maintainers on board with this? I remember the project was approached previously: jbeder/yaml-cpp#963

I have not approached the maintainers of yaml-cpp.
Although, I believe it should be fine since the project is covered under the MIT license agreement.

@DavidKorczynski
Copy link
Collaborator

we need maintainer approval that they are happy to receive and fix bugs

@initializedd
Copy link
Author

we need maintainer approval that they are happy to receive and fix bugs

I will open an issue on the yaml-cpp repository and reference this PR.

@jbeder
Copy link

jbeder commented Dec 17, 2024

Hey, maintainer of yaml-cpp here. As evidenced by my lack of response to your first PR (sorry, @DavidKorczynski!) I don't have a ton of time for this library. I mostly just approve small PRs for bugfixes. I see the concern

The only expectation of integrating into OSS-Fuzz is that bugs will be fixed. This is not a "hard" requirement in that no one enforces this and the main point is if bugs are not fixed then it is a waste of resources to run the fuzzers, which we would like to avoid.

I can't commit to fixing all bugs that OSS-Fuzz comes out with, but I can commit to reviewing any PRs that fix those bugs. @initializedd, would you be willing to commit to (at least trying to) fix bugs?

@DavidKorczynski
Copy link
Collaborator

I can't commit to fixing all bugs that OSS-Fuzz comes out with, but I can commit to reviewing any PRs that fix those bugs. @initializedd, would you be willing to commit to (at least trying to) fix bugs?

The caveat here is that the bugs found are following the Google disclosure policy, which means they will be publicised after 90 days if not fixed (and will be made public once they are fixed too if pre the 90 day deadline).

@initializedd
Copy link
Author

@initializedd, would you be willing to commit to (at least trying to) fix bugs?

I am definitely happy to commit to fixing bugs.

@DavidKorczynski In that case, I assume I would need to add myself to auto_ccs to receive notifications of bugs that have been discovered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants