Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebsockets - html and http headers parsing fuzz targets #12852

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Segwaz
Copy link

@Segwaz Segwaz commented Dec 14, 2024

Extends fuzzing for libwebsockets to cover:

  • HTML parsing (lws_lhp_parse)
  • HTTP headers parsing (lws_parse)

Those additions increase static coverage from 2% to 42%.

Copy link

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Segwaz is a new contributor to projects/libwebsockets. The PR must be approved by known contributors before it can be merged. The past contributors are: lws-team, autofuzzoss

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just so I understand, are you a maintainer of libwebsockets? otherwise, could you reach out to maintainers to help them review the PR?

Ideally we should get these harnesses into the upstrem libwebsockets repository, could you please assist with this instead of landing the code here?

@Segwaz
Copy link
Author

Segwaz commented Dec 15, 2024

I am not a maintainer. I can make the necessary changes once they approve, provided there isn’t a specific reason to keep the current approach.

@Segwaz
Copy link
Author

Segwaz commented Dec 15, 2024

Hi @lws-team , could you please review this PR and confirm if moving the harnesses into the upstream libwebsockets repository would be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants