chronos: fix PATH setting #12845
Merged
chronos: fix PATH setting #12845
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the $PATH bit is expanded, i.e. the ENV string becomes the PATH of the host system, as opposed to the docker container's PATH. We should escape the `$` to ensure we don't overwrite the full PATH
|
Am not sure if this is strictly causing issues since I assume we don't have that many paths in the containers -- but I think it's likely it may be causing issues for some projects. |
|
/gcbrun skip |
AdamKorcz
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the $PATH bit is expanded, i.e. the ENV string becomes the PATH of the host system, as opposed to the docker container's PATH. We should escape the
$to ensure we don't overwrite the full PATH