Save docker images for C/C++ #12831
Save docker images for C/C++ #12831
Conversation
So that bugs can reproduced.
|
/gcbrun skip |
| steps.append(docker_build_arm_step) | ||
|
|
||
| if (not experiment and not config.testing and |
There was a problem hiding this comment.
Do we need to add push as an explicit step? Is it simpler to just add this to https://cloud.google.com/build/docs/build-config-file-schema#images ?
There was a problem hiding this comment.
I recall max removing this step because it failed. I think this way is more performant (it runs in the background) and error-tolerant, but I'd understand if you want the simplicity instead.
I do think all of this builder code may be getting too complicated, too many special cases.
There was a problem hiding this comment.
I recall max removing this step because it failed. I think this way is more performant (it runs in the background) and error-tolerant, but I'd understand if you want the simplicity instead.
I do think all of this builder code may be getting too complicated, too many special cases.
There was a problem hiding this comment.
Yeah, simplifcity is my main motivation -- this is getting way too complicated.
There was a problem hiding this comment.
Got it. I think the failure is problematic though because it can lead to issues filed against users.
There was a problem hiding this comment.
It's been a while so hopefully this is handled better by Cloud Build now. But yeah, good point. If we run into this again your solution is probably the more practical one.
There was a problem hiding this comment.
I'm low on cycles so let's land this for now and fix it later. I'll file an issue so I don't forget to fix this (though i have a feeling build isn't dealing with this better).
So that bugs can reproduced.
These should not be used if security is a concern!
I maybe will put the word unsafe in the name