infra/rust/coverage: copy right toolchain sources #11501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a project uses another toolchain than nightly-x86_64-unknown-linux-gnu we should get sources from this other toolchain
|
@DonggeLiu could this be taken in to fix suricata fuzzing coverage ? (and maybe other rust projects using a custom toolchain) |
|
Requesting help from @jonathanmetzman : ) |
|
/gcbrun trial_build.py rust --fuzzing-engines libfuzzer --sanitizers address |
jonathanmetzman
approved these changes
Jan 23, 2024
|
So, gcb says this fixes suricata but breaks surrealdb Looking into it |
|
Got the fix easy. |
so as to get coverage
catenacyber
force-pushed
the
rustcovdefault
branch
from
e28667a to
d516ecf
Compare
|
friendly ping @jonathanmetzman as ClusterFuzz-External reminds me that suricata Coverage build is still failing ;-) |
|
/gcbrun trial_build.py rust --fuzzing-engines libfuzzer --sanitizers address |
|
trial build all green :-) |
|
@jonathanmetzman is the CFLite failure related/expected to this PR? |
|
@DonggeLiu this PR does not change anything for python ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=65817