Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Go coverage reports #10948

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

AdamKorcz
Copy link
Collaborator

Fixes #10916

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py go --sanitizer address coverage --fuzzing-engines libfuzzer

@DavidKorczynski
Copy link
Collaborator

Looking at the failed trial build there is only 1 project that fails:

Step #1: INFO:root:Summary: trial build failed
Step #1: Failed builds: 1/89, {'kubeedge': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9df7ee5c-7c56-4471-a821-39ad0ccc8f8e.txt'}
Finished Step #1

The log for this project is:

tep #19 - "compile-libfuzzer-address-x86_64": ++ sed 's/klog\./\/\/klog\./g' -i /src/kubeedge/edge/pkg/devicetwin/dtmanager/device.go
Step #19 - "compile-libfuzzer-address-x86_64": ++ sed 's/\"k8s\.io\/klog\/v2"/\/\/\"k8s\.io\/klog\/v2\"/g' -i /src/kubeedge/edge/pkg/devicetwin/dtmanager/device.go
Step #19 - "compile-libfuzzer-address-x86_64": ++ compile_go_fuzzer github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager FuzzdealTwinActions fuzz_deal_twin_actions
Step #19 - "compile-libfuzzer-address-x86_64": /usr/local/bin/compile_go_fuzzer: line 28: cd: /root/go/src/github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager: No such file or directory
Step #19 - "compile-libfuzzer-address-x86_64": github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager
Step #19 - "compile-libfuzzer-address-x86_64": github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager
Step #19 - "compile-libfuzzer-address-x86_64": Running go-fuzz -tags gofuzz -func FuzzdealTwinActions -o fuzz_deal_twin_actions.a github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager
Step #19 - "compile-libfuzzer-address-x86_64": # github.com/cilium/ebpf/internal/btf
Step #19 - "compile-libfuzzer-address-x86_64": vendor/github.com/cilium/ebpf/internal/btf/fuzz.go:20:15: undefined: loadNakedSpec
Step #19 - "compile-libfuzzer-address-x86_64": 2023/09/13 14:07:12 failed to build packages:exit status 2
Step #19 - "compile-libfuzzer-address-x86_64": ********************************************************************************
Step #19 - "compile-libfuzzer-address-x86_64": Failed to build.
Step #19 - "compile-libfuzzer-address-x86_64": To reproduce, run:
Step #19 - "compile-libfuzzer-address-x86_64": python infra/helper.py build_image kubeedge

This seems unrelated, @AdamKorcz can you confirm?

@jonathanmetzman
Copy link
Contributor

This failed also here: #10920 must be a FP.
Let me merge that PR first and then reconfirm this works.

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py go --sanitizer address coverage --fuzzing-engines libfuzzer

@AdamKorcz
Copy link
Collaborator Author

Looking at the failed trial build there is only 1 project that fails:

Step #1: INFO:root:Summary: trial build failed
Step #1: Failed builds: 1/89, {'kubeedge': 'https://oss-fuzz-gcb-logs.storage.googleapis.com/log-9df7ee5c-7c56-4471-a821-39ad0ccc8f8e.txt'}
Finished Step #1

The log for this project is:

tep #19 - "compile-libfuzzer-address-x86_64": ++ sed 's/klog\./\/\/klog\./g' -i /src/kubeedge/edge/pkg/devicetwin/dtmanager/device.go
Step #19 - "compile-libfuzzer-address-x86_64": ++ sed 's/\"k8s\.io\/klog\/v2"/\/\/\"k8s\.io\/klog\/v2\"/g' -i /src/kubeedge/edge/pkg/devicetwin/dtmanager/device.go
Step #19 - "compile-libfuzzer-address-x86_64": ++ compile_go_fuzzer github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager FuzzdealTwinActions fuzz_deal_twin_actions
Step #19 - "compile-libfuzzer-address-x86_64": /usr/local/bin/compile_go_fuzzer: line 28: cd: /root/go/src/github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager: No such file or directory
Step #19 - "compile-libfuzzer-address-x86_64": github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager
Step #19 - "compile-libfuzzer-address-x86_64": github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager
Step #19 - "compile-libfuzzer-address-x86_64": Running go-fuzz -tags gofuzz -func FuzzdealTwinActions -o fuzz_deal_twin_actions.a github.com/kubeedge/kubeedge/edge/pkg/devicetwin/dtmanager
Step #19 - "compile-libfuzzer-address-x86_64": # github.com/cilium/ebpf/internal/btf
Step #19 - "compile-libfuzzer-address-x86_64": vendor/github.com/cilium/ebpf/internal/btf/fuzz.go:20:15: undefined: loadNakedSpec
Step #19 - "compile-libfuzzer-address-x86_64": 2023/09/13 14:07:12 failed to build packages:exit status 2
Step #19 - "compile-libfuzzer-address-x86_64": ********************************************************************************
Step #19 - "compile-libfuzzer-address-x86_64": Failed to build.
Step #19 - "compile-libfuzzer-address-x86_64": To reproduce, run:
Step #19 - "compile-libfuzzer-address-x86_64": python infra/helper.py build_image kubeedge

This seems unrelated, @AdamKorcz can you confirm?

Yes, it is unrelated.

I have seen this several times and should be related to #10884. The gofuzz tag includes files in the scope of the build that are broken.

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathanmetzman jonathanmetzman merged commit 7f893b2 into google:master Sep 13, 2023
18 of 19 checks passed
gedigi pushed a commit to gedigi/oss-fuzz that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add code coverage for compile_native_go_fuzzer?
3 participants