Correct typing usage for Validators #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TypeVar usage was indicating that ALL validators available in _VALIDATORS would have the same type. This update only indicates that these validators are an instance of the ValidatorBase.
dbhatman
changed the title
cricdecyan
approved these changes
Sep 29, 2022
lalten
reviewed
Sep 29, 2022
| @@ -70,8 +70,7 @@ def __call__(self, value) -> bool: | |||
| """Should validate value, returning a boolean result.""" | |||
|
|
|||
|
|
|||
| _ValidatorT = TypeVar("_ValidatorT", bound=ValidatorBase) | |||
| _ValidatorFactoryT = Union[Type[_ValidatorT], Callable[..., _ValidatorT]] | |||
| _ValidatorFactoryT = Union[Callable[..., ValidatorBase]] | |||
There was a problem hiding this comment.
Doesn't this change also mean that e.g. the Equals class (the class itself, not instances of it) can not be used anymore in _VALIDATORS?
I think at least Mypy does not agree that a class type doubles as a Callable[..., Classtype] even if you could argue that the class __init__ makes it behave that way.
There was a problem hiding this comment.
Mypy does agree that Type[C] is a Callable[..., C]: python/mypy#1670
Also interestingly enough ABCs also match: python/mypy#12361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeVar usage was indicating that ALL validators available in _VALIDATORS would have the same type. This update only indicates that these validators are an instance of the ValidatorBase.
Pytype is currently erroring on master and this resolves those errors.
This change is