Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmake support for linux/mac/windows #590

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

rkitover
Copy link

@rkitover rkitover commented May 21, 2019

This is a complete reproduction of the autotools code in cmake, with
improvements where cmake has an advantage.

The options are documented in README.md

Dependencies on Windows with Visual Studio are handled with vcpkg, and
the VCPKG_TARGET_TRIPLET variable can activate vcpkg support on other
platforms as well.

Include the FindPython2 cmake modules as they are not in the base cmake
package on Ubuntu.

Make some minor fixes to the autotools code as well, for things broken
by adding the cmake support and some other fixes.

Signed-off-by: Rafael Kitover [email protected]

This is a complete reproduction of the autotools code in cmake, with
improvements where cmake has an advantage.

The options are documented in README.md

Dependencies on Windows with Visual Studio  are handled with vcpkg, and
the `VCPKG_TARGET_TRIPLET` variable can activate vcpkg support on other
platforms as well.

Include the FindPython2 cmake modules as they are not in the base cmake
package on Ubuntu.

Make some minor fixes to the autotools code as well, for things broken
by adding the cmake support and some other fixes.

Signed-off-by: Rafael Kitover <[email protected]>
@rkitover rkitover changed the title initial cmake support for linux/mac add cmake support for linux/mac/windows Jun 4, 2019
@rkitover
Copy link
Author

rkitover commented Jun 4, 2019

@goatpig this is the work Scott Millar contracted me to do on upwork.

I just updated it with my latest changes.

Windows support now works as well, seamlessly with dependency handling through vcpkg, at least for ArmoryDB.

This version should be mostly complete and does everything the autotools code does.

Some of this cmake code needs to be sent upstream to the relevant libraries, with appropriate changes, but that's a separate project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant