Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix gleam_httpc_test.ipv6_test #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sobolevn
Copy link

  1) gleam_httpc_test.ipv6_test
     #{function => <<"ipv6_test">>,line => 99,
       message => <<"Assertion pattern match failed">>,
       module => <<"gleam_httpc_test">>,
       value =>
           {error,{failed_to_connect,{posix,<<"nxdomain">>},
                                     {posix,<<"enetunreach">>}}},
       gleam_error => let_assert}
     location: gleam_httpc_test.ipv6_test:99
     stacktrace:
       gleam_httpc_test.ipv6_test
     output: 

Finished in 3.240 seconds
9 tests, 1 failures

Example: https://github.com/gleam-lang/httpc/actions/runs/11917211450/job/33211719847

Let's try this approach.

```
  1) gleam_httpc_test.ipv6_test
     #{function => <<"ipv6_test">>,line => 99,
       message => <<"Assertion pattern match failed">>,
       module => <<"gleam_httpc_test">>,
       value =>
           {error,{failed_to_connect,{posix,<<"nxdomain">>},
                                     {posix,<<"enetunreach">>}}},
       gleam_error => let_assert}
     location: gleam_httpc_test.ipv6_test:99
     stacktrace:
       gleam_httpc_test.ipv6_test
     output: 

Finished in 3.240 seconds
9 tests, 1 failures
```

Example: https://github.com/gleam-lang/httpc/actions/runs/11917211450/job/33211719847
@lpil
Copy link
Member

lpil commented Nov 20, 2024

Could you explain the change here please 🙏

@sobolevn
Copy link
Author

https://ipv6.google.com gives 404 now, https://ipv6test.google.com works similar.

@lpil
Copy link
Member

lpil commented Nov 20, 2024

What's that error you've pasted above? It's not a 404.

How come the test is passing on GitHub actions now? GitHub doesn't have IPv6 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants