Allow setting recv_timeout when sending request #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Aye you're right, we'll need to adjust a bit to avoid breaking existing code. It would be nice to also leave the door open for more configuration. Perhaps we could provide another API here using the builder pattern? request
|> hackney.configure
|> hackney.receive_timeout_ms(5000)
|> hackney.dispatch_bits |
felixyz
force-pushed
the
timeout-option
branch
from
867b807 to
eab311f
Compare
|
I guess I should at least have run the tests 😇 @lpil Yes builder is clearly the way to go. I'm on it. |
felixyz
force-pushed
the
timeout-option
branch
from
eab311f to
c7bae44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a longer timeout so added the ability to set it manually. Happy to refactor if would risk breaking anyone's code (if they are calling
send_bitsdirectly).