Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump url from 2.5.2 to 2.5.3 #124

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Bump url from 2.5.2 to 2.5.3 #124

merged 1 commit into from
Nov 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Bumps url from 2.5.2 to 2.5.3.

Release notes

Sourced from url's releases.

v2.5.3

What's Changed

New Contributors

Full Changelog: servo/rust-url@v2.5.2...v2.5.3

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 4, 2024 20:04
@dependabot dependabot bot added dependencies rust Pull requests that update Rust code labels Nov 4, 2024
@jorendorff
Copy link
Contributor

jorendorff commented Nov 5, 2024

Sigh, this brings in a bunch of heavy new dependencies, because it aims to support some Unicode stuff I don't understand.

url depends on idna_adaptor which depends on idna which brings in a bunch of ICU libraries. There is a workaround available, idna_adaptor, but I think it's up to the end user to find it and use it.

Bumps [url](https://github.com/servo/rust-url) from 2.5.2 to 2.5.3.
- [Release notes](https://github.com/servo/rust-url/releases)
- [Commits](servo/rust-url@v2.5.2...v2.5.3)

---
updated-dependencies:
- dependency-name: url
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/url-2.5.3 branch from 3f5e52f to c562008 Compare November 11, 2024 16:00
@hendrikvanantwerpen
Copy link
Contributor

@jorendorff Should this even have a Cargo.lock in the repo, since it's a library? Without it, dependabot would certainly be less noisy.

@jorendorff
Copy link
Contributor

@jorendorff Should this even have a Cargo.lock in the repo, since it's a library? Without it, dependabot would certainly be less noisy.

Committing Cargo.lock is optional for library crates. It doesn't affect downstream users. It does affect what happens in CI. I think we should keep it because CI is more deterministic that way, and if a point release of a dependency ever does break us, we'll find out about it in the dependabot PR to update that dependency, rather than the next time we want to merge some other unrelated change, or when a user complains.

@jorendorff jorendorff added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 20e0a3d Nov 12, 2024
2 checks passed
@jorendorff jorendorff deleted the dependabot/cargo/url-2.5.3 branch November 12, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants