-
Notifications
You must be signed in to change notification settings - Fork 60
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #42 from github/json
feat: add JSON output
- Loading branch information
Showing
6 changed files
with
229 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# Output files | ||
issue_metrics.md | ||
issue_metrics.json | ||
|
||
# Byte-compiled / optimized / DLL files | ||
__pycache__/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
"""A module for writing GitHub issue metrics to a json file. | ||
Functions: | ||
write_to_json( | ||
issues_with_metrics: List[IssueWithMetrics], | ||
average_time_to_first_response: timedelta, | ||
average_time_to_close: timedelta, | ||
average_time_to_answer: timedelta, | ||
num_issues_opened: int, | ||
num_issues_closed: int, | ||
) -> str: | ||
Write the issues with metrics to a json file. | ||
""" | ||
|
||
|
||
import json | ||
from datetime import timedelta | ||
import os | ||
from typing import List, Union | ||
|
||
from classes import IssueWithMetrics | ||
|
||
|
||
def write_to_json( | ||
issues_with_metrics: Union[List[IssueWithMetrics], None], | ||
average_time_to_first_response: Union[timedelta, None], | ||
average_time_to_close: Union[timedelta, None], | ||
average_time_to_answer: Union[timedelta, None], | ||
num_issues_opened: Union[int, None], | ||
num_issues_closed: Union[int, None], | ||
) -> str: | ||
""" | ||
Write the issues with metrics to a JSON file called issue_metrics.json. | ||
json structure is like following | ||
{ | ||
"average_time_to_first_response": "2 days, 12:00:00", | ||
"average_time_to_close": "5 days, 0:00:00", | ||
"average_time_to_answer": "1 day, 0:00:00", | ||
"num_items_opened": 2, | ||
"num_items_closed": 1, | ||
"total_item_count": 2, | ||
"issues": [ | ||
{ | ||
"title": "Issue 1", | ||
"html_url": "https://github.com/owner/repo/issues/1", | ||
"time_to_first_response": "3 days, 0:00:00", | ||
"time_to_close": "6 days, 0:00:00", | ||
"time_to_answer": "None", | ||
}, | ||
{ | ||
"title": "Issue 2", | ||
"html_url": "https://github.com/owner/repo/issues/2", | ||
"time_to_first_response": "2 days, 0:00:00", | ||
"time_to_close": "4 days, 0:00:00", | ||
"time_to_answer": "1 day, 0:00:00", | ||
}, | ||
], | ||
} | ||
""" | ||
|
||
# Ensure issues_with_metrics is not None | ||
if not issues_with_metrics: | ||
return "" | ||
|
||
# Create a dictionary with the metrics | ||
metrics = { | ||
"average_time_to_first_response": str(average_time_to_first_response), | ||
"average_time_to_close": str(average_time_to_close), | ||
"average_time_to_answer": str(average_time_to_answer), | ||
"num_items_opened": num_issues_opened, | ||
"num_items_closed": num_issues_closed, | ||
"total_item_count": len(issues_with_metrics), | ||
} | ||
|
||
# Create a list of dictionaries with the issues and metrics | ||
issues = [] | ||
for issue in issues_with_metrics: | ||
issues.append( | ||
{ | ||
"title": issue.title, | ||
"html_url": issue.html_url, | ||
"time_to_first_response": str(issue.time_to_first_response), | ||
"time_to_close": str(issue.time_to_close), | ||
"time_to_answer": str(issue.time_to_answer), | ||
} | ||
) | ||
|
||
# Add the issues to the metrics dictionary | ||
metrics["issues"] = issues | ||
|
||
# add output to github action output | ||
# pylint: disable=unspecified-encoding | ||
metrics_json = json.dumps(metrics) | ||
if os.environ.get("GITHUB_OUTPUT"): | ||
with open(os.environ["GITHUB_OUTPUT"], "a") as file_handle: | ||
print(f"metrics={metrics_json}", file=file_handle) | ||
|
||
# Write the metrics to a JSON file | ||
with open("issue_metrics.json", "w", encoding="utf-8") as file: | ||
json.dump(metrics, file, indent=4) | ||
|
||
return metrics_json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
"""Tests for the write_to_json function in json_writer.py.""" | ||
|
||
import json | ||
import unittest | ||
from datetime import timedelta | ||
from classes import IssueWithMetrics | ||
from json_writer import write_to_json | ||
|
||
|
||
class TestWriteToJson(unittest.TestCase): | ||
"""Tests for the write_to_json function.""" | ||
|
||
def test_write_to_json(self): | ||
"""Test that write_to_json writes the correct JSON file.""" | ||
issues_with_metrics = [ | ||
IssueWithMetrics( | ||
title="Issue 1", | ||
html_url="https://github.com/owner/repo/issues/1", | ||
time_to_first_response=timedelta(days=3), | ||
time_to_close=timedelta(days=6), | ||
time_to_answer=None, | ||
), | ||
IssueWithMetrics( | ||
title="Issue 2", | ||
html_url="https://github.com/owner/repo/issues/2", | ||
time_to_first_response=timedelta(days=2), | ||
time_to_close=timedelta(days=4), | ||
time_to_answer=timedelta(days=1), | ||
), | ||
] | ||
average_time_to_first_response = timedelta(days=2.5) | ||
average_time_to_close = timedelta(days=5) | ||
average_time_to_answer = timedelta(days=1) | ||
num_issues_opened = 2 | ||
num_issues_closed = 1 | ||
|
||
expected_output = { | ||
"average_time_to_first_response": "2 days, 12:00:00", | ||
"average_time_to_close": "5 days, 0:00:00", | ||
"average_time_to_answer": "1 day, 0:00:00", | ||
"num_items_opened": 2, | ||
"num_items_closed": 1, | ||
"total_item_count": 2, | ||
"issues": [ | ||
{ | ||
"title": "Issue 1", | ||
"html_url": "https://github.com/owner/repo/issues/1", | ||
"time_to_first_response": "3 days, 0:00:00", | ||
"time_to_close": "6 days, 0:00:00", | ||
"time_to_answer": "None", | ||
}, | ||
{ | ||
"title": "Issue 2", | ||
"html_url": "https://github.com/owner/repo/issues/2", | ||
"time_to_first_response": "2 days, 0:00:00", | ||
"time_to_close": "4 days, 0:00:00", | ||
"time_to_answer": "1 day, 0:00:00", | ||
}, | ||
], | ||
} | ||
|
||
# Call the function and check the output | ||
self.assertEqual( | ||
write_to_json( | ||
issues_with_metrics, | ||
average_time_to_first_response, | ||
average_time_to_close, | ||
average_time_to_answer, | ||
num_issues_opened, | ||
num_issues_closed, | ||
), | ||
json.dumps(expected_output), | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters