Add more response splitting sinks #5937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to Tomcat implementation, HTTP response splitting is not possible via HTTP Header injection. Other implementations may be vulnerable but that would be a vulnerability on those implementations. |
So what's the conclusion here? Should this PR be merged or dropped? |
|
I think we can drop it, but will leave the last word to @atorralba |
|
I think the conclusion was to not add this to the default Response Splitting query but to create a new, opt-in Response Splitting query with those extra sinks so that customers can use them if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more methods of
javax.servlet.http.HttpServletResponseas response splitting sinks.@aschackmull @smowton
cc: @pwntester @atorralba