Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Replace usage of toString() for Javadoc queries; add more Javadoc tags #5815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Marcono1234
Copy link
Contributor

  • Replace usage of toString() for checking Javadoc text
  • Model more Javadoc block tags as CodeQL class
  • Move getATag(string) from JavadocParent to Javadoc since JavadocTag (which also extends JavadocParent) cannot have nested Javadoc block tags (as far as I know)

Note that due to #3696 the added predicate for JavadocParent has to be getATextElement() since multi-line comments are separate JavadocText elements.
Additionally in the future the added CodeQL classes for @return and @deprecated might need proper predicates for handling multi-line text, but that is blocked by #3825.

@Marcono1234 Marcono1234 requested a review from a team as a code owner April 30, 2021 23:25
@github-actions github-actions bot added the Java label Apr 30, 2021
@Marcono1234 Marcono1234 force-pushed the marcono1234/javadoc branch from 6b86a91 to dc1f563 Compare April 30, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant