JS: use the class hierarchy from TypeScript in the callgraph #5694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
Awaiting evaluation
erik-krogh
force-pushed
the
typedCall
branch
5 times, most recently
from
506abc0 to
51f4e01
Compare
erik-krogh
force-pushed
the
typedCall
branch
4 times, most recently
from
d39cd2f to
9d078d3
Compare
erik-krogh
force-pushed
the
typedCall
branch
from
9d078d3 to
4b4b7c6
Compare
erik-krogh
force-pushed
the
typedCall
branch
from
e0b6831 to
d0f8f33
Compare
|
QHelp previews: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a taint-step for CVE-2020-27224.
From this call to this callee.
I'm trying to run an evaluation, but
vscodekeeps being weird.In the vast majority of evaluations
vscodetimes out on the new branch (but not always).Some evaluations where
vscodetimed out: 1, 2, 3, 4, 5.But here is an evaluation where
vscoderan just fine.I'm trying out another evaluation with the same SHAs, I expect
vscodeto time out.Edit: I've figured something out. Some commits of
vscodetimes out, and others do not.But I just can't replicate it locally. It always runs fine locally.
I've tried both with a DB build by LGTM and a locally build DB.
If you ignore
vscode, then there definitely is a performance regression on big TypeScript projects (mostlyangular).But that performance regression is due to there being more call-edges, and thus more flow.
The callgraph computation still runs plenty fast.
So I think the performance regression is acceptable.
Update. VSCode only timed out sometimes because extraction changed a lot depending on whether we used the latest TS version or not.
And with eveything the latest, VSCode still times out.