C#: Add data flow tests for various pattern types #5429
+898
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hvitved I added a couple of test cases for data flow on patterns. At one point, let's discuss which ones to tackle next... |
hvitved
reviewed
Mar 22, 2021
| var ret1 = a switch | ||
| { | ||
| Item("taint source", 1) { Y: 10 } z => Sink(z.X), // [TRUE POSITIVE] | ||
| Item("not taint source", 1) { Y: 10 } z => Sink(z.X), // [FALSE POSITIVE] |
There was a problem hiding this comment.
I don't think this is a false positive, as far as data flow is concerned. This is instead something where I would expect a given data flow configuration to prune data flow edges using guards.
It is basically the same as
var x = "tainted";
if (x == "not tainted")
Sink(x);| var ret2 = b switch | ||
| { | ||
| ("taint source", 0) => Sink(b.X), // [TRUE POSITIVE] | ||
| ("not taint source", 0) => Sink(b.X), // [FALSE POSITIVE] |
| ("taint source", 0) => Sink(b.X), // [TRUE POSITIVE] | ||
| ("not taint source", 0) => Sink(b.X), // [FALSE POSITIVE] | ||
| ("taint source", 3) p => Sink(p.X), // [TRUE POSITIVE] | ||
| ("not taint source", 3) p => Sink(p.X), // [FALSE POSITIVE] |
| var ret3 = o switch | ||
| { | ||
| Item("taint source", 1) { Y: 10 } z => Sink(z.X), // [TRUE POSITIVE] | ||
| Item("not taint source", 1) { Y: 10 } z => Sink(z.X), // [FALSE POSITIVE] |
| var ret4 = tup switch | ||
| { | ||
| ("taint source", 2) => Sink(tup.Item1), // [TRUE POSITIVE] | ||
| ("not taint source", 2) => Sink(tup.Item1), // [FALSE POSITIVE] |
| ("taint source", 2) => Sink(tup.Item1), // [TRUE POSITIVE] | ||
| ("not taint source", 2) => Sink(tup.Item1), // [FALSE POSITIVE] | ||
| ValueTuple<string, int>("taint source", 3) { Item2: 3 } t1 => Sink(tup.Item1), // [TRUE POSITIVE] | ||
| ValueTuple<string, int>("not taint source", 3) { Item2: 3 } t1 => Sink(tup.Item1), // [FALSE POSITIVE] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.