Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Actions queries to public repo #18321

Merged
merged 855 commits into from
Dec 19, 2024
Merged

Migrate Actions queries to public repo #18321

merged 855 commits into from
Dec 19, 2024

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented Dec 18, 2024

This PR adds the sources for the codeql/actions-queries query pack and codeql/actions-all library pack, as well as the corresponding test pack. The query pack is already in public preview.

The only changes from the previously private source code are:

  1. Moved dependency versions to use ${workspace} now that the dependencies are in the same workspace as the new packs.
  2. Bumped version number to 0.4.0-dev to fit with the new repo's versioning process.
  3. Updated lock files.
  4. Disable QlDoc checks for Actions, pending resolution of an internal issue to fix them.
  5. Fixed formatting.
  6. Fixed one QL-on-QL error, although there are a bunch of style alerts still open.

The commit history is preserved from the original internal repository via a baseless merge.

pwntester and others added 30 commits September 10, 2024 09:49
When running codeql test run, the root of the database is not the root
of the original repo (the directory containing .github and .git)
therefore calls to reusable workflows are not correctly matched.
…cking

Problem is that there are StoreSteps that depend on PRHeadCheckout so
there is a non-monotic recursion error since PRHeadCheckout depends on
TaintTracking module, but this module depends on PRHeadCheckout
Add models for list-files actions
feat: Improve sanitizer checks
Modify UnpinnedActionsTag report node
Cross remote Reusable Workflow analysis
@github-actions github-actions bot added documentation Actions Analysis of GitHub Actions labels Dec 18, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@dbartol dbartol marked this pull request as ready for review December 19, 2024 15:16
@dbartol dbartol requested a review from a team as a code owner December 19, 2024 15:16
Copy link
Collaborator

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall structure, history, and workflow changes look good. I didn't review all the libraries (!) but I see internal CI is passing and we can make iterative improvements over time.

@dbartol dbartol merged commit 772b972 into main Dec 19, 2024
11 checks passed
@dbartol dbartol deleted the dbartol/actions-merge branch December 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants