-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Actions queries to public repo #18321
Conversation
When running codeql test run, the root of the database is not the root of the original repo (the directory containing .github and .git) therefore calls to reusable workflows are not correctly matched.
…cking Problem is that there are StoreSteps that depend on PRHeadCheckout so there is a non-monotic recursion error since PRHeadCheckout depends on TaintTracking module, but this module depends on PRHeadCheckout
Add models for list-files actions
feat: Improve sanitizer checks
Modify UnpinnedActionsTag report node
Improve reusable workflow calls
Cross remote Reusable Workflow analysis
Expect external workflows and actions in .github/workflow/external and .github/actions/external
Fix typo in UnversionedImmutableAction.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file not yet fully implemented and does not compile
Failure tracked in github/codeql-team#3655
This reverts commit dba6f0b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall structure, history, and workflow changes look good. I didn't review all the libraries (!) but I see internal CI is passing and we can make iterative improvements over time.
This PR adds the sources for the
codeql/actions-queries
query pack andcodeql/actions-all
library pack, as well as the corresponding test pack. The query pack is already in public preview.The only changes from the previously private source code are:
${workspace}
now that the dependencies are in the same workspace as the new packs.0.4.0-dev
to fit with the new repo's versioning process.The commit history is preserved from the original internal repository via a baseless merge.