Java: Add test for a JavacTool-based compiler that doesn't use standard JavaFileObjects #18305
+110
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- java/ql/integration-tests/java/javac-tool-custom-file/test.expected: Language not supported
- java/ql/integration-tests/java/javac-tool-custom-file/test.ql: Language not supported
Tip: Turn on automatic Copilot reviews for this repository to get quick feedback on every pull request. Learn more
smowton
force-pushed
the
smowton/admin/agent-extracted-file-test
branch
from
4ec706a to
898995f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the situation where a JavacTool-based compiler doesn't just refer to standard files on disk, but rather directly refers to source files in a JAR or other archive, or as in the case tested here, uses an in-memory file object backed by a buffer, not a file.
The Java agent previously couldn't deal with this, but should now read such files out as text and write them to a temporary directory before extracting them.