C#: Move external api declarations to the library pack. #18303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
refactorlibrarylocations
branch
from
1450df5 to
bd9f656
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (12)
- csharp/ql/lib/semmle/code/csharp/telemetry/ExternalApi.qll: Language not supported
- csharp/ql/lib/semmle/code/csharp/telemetry/TestLibrary.qll: Language not supported
- csharp/ql/src/Telemetry/ExternalApi.qll: Language not supported
- csharp/ql/src/Telemetry/ExternalLibraryUsage.ql: Language not supported
- csharp/ql/src/Telemetry/SupportedExternalApis.ql: Language not supported
- csharp/ql/src/Telemetry/SupportedExternalSinks.ql: Language not supported
- csharp/ql/src/Telemetry/SupportedExternalSources.ql: Language not supported
- csharp/ql/src/Telemetry/SupportedExternalTaint.ql: Language not supported
- csharp/ql/src/Telemetry/TestLibrary.qll: Language not supported
- csharp/ql/src/Telemetry/UnsupportedExternalAPIs.ql: Language not supported
- csharp/ql/src/meta/frameworks/UnsupportedExternalAPIs.ql: Language not supported
- csharp/ql/src/utils/modeleditor/ModelEditor.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
hvitved
approved these changes
Dec 17, 2024
|
DCA looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we move a couple of modules to the library pack as they are re-usable in the CodeQL community pack (then we can avoid having a dependency to the CodeQL C# query pack from the CodeQL community pack repo).