Fix code review findings

github · Apr 23, 2021 · 1b4c3c7 · 1b4c3c7
1 parent a8a920c
commit 1b4c3c7
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/csharp/ql/src/semmle/code/csharp/security/dataflow/flowsources/Local.qll b/csharp/ql/src/semmle/code/csharp/security/dataflow/flowsources/Local.qll
@@ -26,11 +26,9 @@ class SystemConsoleReadSource extends LocalUserInputSource {
   SystemConsoleReadSource() {
     this.asExpr() =
       any(MethodCall call |
-        call.getTarget().hasQualifiedName("System.Console", "ReadLine") or
-        call.getTarget().hasQualifiedName("System.Console", "Read") or
-        call.getTarget().hasQualifiedName("System.Console", "ReadKey")
+        call.getTarget().hasQualifiedName("System.Console", ["ReadLine", "Read", "ReadKey"])
       )
   }
 
-  override string getSourceType() { result = "TextBox text" }
+  override string getSourceType() { result = "System.Console input" }
 }