open-pr: fix the Git LFS link to use when opening a PR #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been reported in git-for-windows/git#5276 (comment) that the Git LFS link in the release notes was incorrect. The reason is that we have some special handling of Git LFS so that we do not get the (rather ugly) _tag_ URL but instead the _release_ URL. Example: git-for-windows/git#5266 refers to https://github.com/git-lfs/git-lfs/releases/tag/v3.6.0 because this is the URL from the feed from which the `monitor-components` gets it: https://github.com/git-for-windows/git/blob/v2.47.1.windows.1/.github/workflows/monitor-components.yml#L29-L3 The corresponding PR at git-for-windows/build-extra#581 (opened via `/open pr` at git-for-windows/git#5266 (comment)) has the link https://github.com/git-lfs/git-lfs/releases/tag/3.6.0 (note the missing `v` after the last slash). This commit ensures that future `/open pr`s in Git LFS issues will use the correct link. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been reported that the Git LFS link in the release notes was incorrect.
The reason is that we have some special handling of Git LFS so that we do not get the (rather ugly) tag URL but instead the release URL.
Example: git-for-windows/git#5266 refers to https://github.com/git-lfs/git-lfs/releases/tag/v3.6.0 because this is the URL from the feed from which the
monitor-componentsgets itThe corresponding PR (opened via
/open pr) has the link https://github.com/git-lfs/git-lfs/releases/tag/3.6.0 (note the missingvafter the last slash).This PR ensures that future
/open prs in Git LFS issues will use the correct link.