Skip to content

Commit

Permalink
open-pr: fix the Git LFS link to use when opening a PR
Browse files Browse the repository at this point in the history
It has been reported in
git-for-windows/git#5276 (comment)
that the Git LFS link in the release notes was incorrect.

The reason is that we have some special handling of Git LFS so that we
do not get the (rather ugly) _tag_ URL but instead the _release_ URL.

Example: git-for-windows/git#5266 refers to
https://github.com/git-lfs/git-lfs/releases/tag/v3.6.0 because this is
the URL from the feed from which the `monitor-components` gets it:
https://github.com/git-for-windows/git/blob/v2.47.1.windows.1/.github/workflows/monitor-components.yml#L29-L3

The corresponding PR at
git-for-windows/build-extra#581 (opened via
`/open pr` at
git-for-windows/git#5266 (comment))
has the link https://github.com/git-lfs/git-lfs/releases/tag/3.6.0 (note
the missing `v` after the last slash).

This commit ensures that future `/open pr`s in Git LFS issues will use
the correct link.

Signed-off-by: Johannes Schindelin <[email protected]>
  • Loading branch information
dscho committed Nov 28, 2024
1 parent 1b40a1b commit a9c3788
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/open-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ jobs:
const version = process.env.UPGRADE_TO_VERSION
if (name === 'mintty') body = `See https://github.com/mintty/mintty/releases/tag/${version} for details.`
else if (name === 'mingw-w64-git-lfs') body = `See https://github.com/git-lfs/git-lfs/releases/tag/${version} for details.`
else if (name === 'mingw-w64-git-lfs') body = `See https://github.com/git-lfs/git-lfs/releases/tag/v${version} for details.`
else if (name === 'mingw-w64-pcre2') body = `See https://github.com/PCRE2Project/pcre2/blob/pcre2-${version}/ChangeLog for details.`
const terms = 'type:issue repo:git-for-windows/git state:open author:app/github-actions label:component-update'
Expand Down

0 comments on commit a9c3788

Please sign in to comment.