Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal): allow priorities script to load filters from remote #4508

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

seia-soto
Copy link
Member

@seia-soto seia-soto commented Dec 10, 2024

We're filtering invalid filters out from our backend and this is preventing us to acquire a proper sight.

// bin/zsh
// Go to ./packages/adblocker from repository root
[[ "$(readlink -f)" != *"/packages/adblocker/"* ]] && cd packages/adblocker

// Use remote filter lists (not from our backend = local files)
// -o, --use-origin-filter
yarn tsx ./scripts/priorities.ts -o

// Use remote filter lists but always fetch
// -i, --ignore-cache
//   ... this option is only effective with -o
yarn tsx ./scripts/priorities.ts -o -i

We're filtering invalid filters out from our backend and this is preventing us to acquire a proper sight.
@seia-soto seia-soto added the PR: Internal 🏠 Changes only affect internals label Dec 10, 2024
@seia-soto seia-soto self-assigned this Dec 10, 2024
@seia-soto seia-soto marked this pull request as ready for review December 11, 2024 07:24
@seia-soto seia-soto requested a review from remusao as a code owner December 11, 2024 07:24
Copy link
Member

@chrmod chrmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs more investigation. Perhaps it is incorrect that we remove those filters on the CI.

@seia-soto seia-soto marked this pull request as draft December 13, 2024 06:22
@seia-soto
Copy link
Member Author

Converting this to draft to prevent this being merged accidentally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants