Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-actions-labeler: initial commit #7330

Merged
merged 2 commits into from
May 18, 2024

Conversation

mofosyne
Copy link
Collaborator

@mofosyne mofosyne commented May 16, 2024

This is an attempt at solving this idea #7174 of using https://github.com/actions/labeler to help assist in auto labeling PR based on file edited content.

Was hoping for PR complexity automation, but this particular github action doesn't appear to have enough flexibility for such logic. But this should help if it works.

I don't have a way to test this, so maybe have a quick lookover and it if makes sense and we can risk it, let's give it a shot.


Also made an issue ticket directly to the team at labeler to see if there is a possibility of having enumerated labels so we can better add auto complexity marking. actions/labeler#781

@mofosyne mofosyne added Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level devops improvements to build systems and github actions labels May 16, 2024
@mofosyne
Copy link
Collaborator Author

Btw on a side note... would it make sense to add paths-ignore to github actions to skip any markdown or doc only changes? How often do we only do documentation changes to this repo? If it's common enough, then it may be worth it.
(But I suspect this may be premature optimization to worry about this)

name: CI

on:
  pull_request:
    types: [opened, reopened, synchronize]
    paths-ignore:
      - '**/*.md' # Ignore markdown files
      - 'docs/**' # Ignore changes in the docs folder

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore

@mofosyne mofosyne requested a review from ggerganov May 16, 2024 13:55
@mofosyne mofosyne force-pushed the 7174-pr-autolabeler branch 2 times, most recently from e49437e to 7df251d Compare May 17, 2024 03:34
@mofosyne mofosyne force-pushed the 7174-pr-autolabeler branch from 7df251d to 83d000d Compare May 17, 2024 03:42
Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the complexity labels are not really useful because they are subjective. We can keep them for now, but I wouldn't mind if we proceed without them

@ggerganov
Copy link
Owner

Btw on a side note... would it make sense to add paths-ignore to github actions to skip any markdown or doc only changes? How often do we only do documentation changes to this repo?

We already seem to skip most of the CI for doc-only changes:

9c4fdcb

@mofosyne mofosyne merged commit de73196 into ggerganov:master May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions Review Complexity : Medium Generally require more time to grok but manageable by beginner to medium expertise level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants