Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBO in OWL files are inconsistent #2157

Closed
cthoyt opened this issue Nov 2, 2023 · 10 comments
Closed

OBO in OWL files are inconsistent #2157

cthoyt opened this issue Nov 2, 2023 · 10 comments

Comments

@cthoyt
Copy link
Contributor

cthoyt commented Nov 2, 2023

Related to discussion at information-artifact-ontology/ontology-metadata#157, there are three artifacts of the OBO in OWL ontology in this repo:

  1. https://github.com/geneontology/go-ontology/blob/master/contrib/oboInOwl and https://github.com/geneontology/go-ontology/blob/master/contrib/oboInOwl.owl are OWL serializations
  2. https://github.com/geneontology/go-ontology/blob/master/contrib/oboInOwl.obo is an OBO serialization

It appears that the OBO serialization is missing some key annotation properties, such as SynonymTypeProperty, which is available in the OWL serialization: https://github.com/geneontology/go-ontology/blob/master/contrib/oboInOwl#L474

How can we keep the OBO file up to date with the OWL one?

@matentzn
Copy link

matentzn commented Nov 2, 2023

@kltm @balhoff what is this oboInOwl file used for? A reference for humans, or is it used in some computational pipeline as well? If the former, can we just make PRs to fix it when we spot issues, and refer to the artefact as the "OBO Format Vocabulary"?

@balhoff
Copy link
Member

balhoff commented Nov 2, 2023

@matentzn @cthoyt I'm not aware that GO uses this file for anything at all. I've never seen an ontology actually import this terminology either.

@matentzn
Copy link

matentzn commented Nov 2, 2023

If you dont know a use case, I would say @cthoyt you can just make a PR.

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 3, 2023

I tried doing robot convert but got a massive diff... not sure if that would be acceptable for a PR

@balhoff
Copy link
Member

balhoff commented Nov 3, 2023

@cthoyt give it a try, and we will look at the ROBOT semantic diff.

@kltm
Copy link
Member

kltm commented Nov 3, 2023

I believe that @cmungall might know some of the history here.

@cmungall cmungall transferred this issue from geneontology/go-ontology Nov 3, 2023
@cmungall
Copy link
Member

cmungall commented Nov 3, 2023

Here is the history, but it's not very relevant. The oboInOwl vocabulary is encoded using an old version of the obo to owl mapping (https://www.bioontology.org/wiki/OboInOwl:Main_Page) that predated OWL2, and hence uses blank nodes and nested objects. This is suboptimal for multiple reasons, but it actually has zero impact as others have said here, the main use case for this vocabulary is as a source or URIs.

I wouldn't try and convert what is there to obo format using modern tools, that doesn't make sense since the owlapi uses a different mapping. I would just hand convert the owl to a normal owl2 representation. Then the obo conversion will make sense. This isn't a priority for any of us in GO but we would accept PRs

@pgaudet
Copy link
Contributor

pgaudet commented Nov 6, 2023

@cthoyt Do you want to convert the file?

Otherwise we'll close without fix, as this is not a high priority for us. But thanks for pointing that out!

Pascale

@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 6, 2023

Unfortunately, as Chris mentioned, it's not possible to use modern tooling to update the OBO file from OWL (geneontology/go-ontology#26371)

I'm disappointed that we can't come up with a first party solution for this, as it means that people who aren't insiders with knowledge of the history might not be able to easily interact with and understand the oboInOwl namespace.

Let's close this issue for now and when I get around to it, I will do my best to modernize the resources in the GO repo

@cthoyt cthoyt closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
@cmungall
Copy link
Member

cmungall commented Nov 8, 2023

Hi Charlie, I'm not sure what you mean by "we can't come up with a first party solution for this", the correct solution is to make oboInOwl conform to modern oboInOwl - I'll see if I can find the time to do this, but not sure when, but the blocker is entirely resources/priorities

cthoyt added a commit to biopragmatics/bioregistry that referenced this issue Nov 16, 2023
This PR updates the OBO in OWL record (see current record at
https://bioregistry.io/oboinowl) in the following ways:

1. Uses pseudo-PURLs for OBO and OWL download that correspond to the
URIs
2. Add @kltm as the contact person. There's still some ambiguity as to
how this file is maintained, but since the URIs point to the GO repo, I
think this is probably a good call for now
3. Adds a loose pattern
4. Adds additional examples


@matentzn @kltm I would love to have one of you contribute a more
detailed description


See related recent discussions:

1. geneontology/go-site#2157
2.
information-artifact-ontology/ontology-metadata#157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants