-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBO in OWL files are inconsistent #2157
Comments
If you dont know a use case, I would say @cthoyt you can just make a PR. |
I tried doing |
@cthoyt give it a try, and we will look at the ROBOT semantic diff. |
I believe that @cmungall might know some of the history here. |
Here is the history, but it's not very relevant. The oboInOwl vocabulary is encoded using an old version of the obo to owl mapping (https://www.bioontology.org/wiki/OboInOwl:Main_Page) that predated OWL2, and hence uses blank nodes and nested objects. This is suboptimal for multiple reasons, but it actually has zero impact as others have said here, the main use case for this vocabulary is as a source or URIs. I wouldn't try and convert what is there to obo format using modern tools, that doesn't make sense since the owlapi uses a different mapping. I would just hand convert the owl to a normal owl2 representation. Then the obo conversion will make sense. This isn't a priority for any of us in GO but we would accept PRs |
@cthoyt Do you want to convert the file? Otherwise we'll close without fix, as this is not a high priority for us. But thanks for pointing that out! Pascale |
Unfortunately, as Chris mentioned, it's not possible to use modern tooling to update the OBO file from OWL (geneontology/go-ontology#26371) I'm disappointed that we can't come up with a first party solution for this, as it means that people who aren't insiders with knowledge of the history might not be able to easily interact with and understand the Let's close this issue for now and when I get around to it, I will do my best to modernize the resources in the GO repo |
Hi Charlie, I'm not sure what you mean by "we can't come up with a first party solution for this", the correct solution is to make oboInOwl conform to modern oboInOwl - I'll see if I can find the time to do this, but not sure when, but the blocker is entirely resources/priorities |
This PR updates the OBO in OWL record (see current record at https://bioregistry.io/oboinowl) in the following ways: 1. Uses pseudo-PURLs for OBO and OWL download that correspond to the URIs 2. Add @kltm as the contact person. There's still some ambiguity as to how this file is maintained, but since the URIs point to the GO repo, I think this is probably a good call for now 3. Adds a loose pattern 4. Adds additional examples @matentzn @kltm I would love to have one of you contribute a more detailed description See related recent discussions: 1. geneontology/go-site#2157 2. information-artifact-ontology/ontology-metadata#157
Related to discussion at information-artifact-ontology/ontology-metadata#157, there are three artifacts of the OBO in OWL ontology in this repo:
It appears that the OBO serialization is missing some key annotation properties, such as
SynonymTypeProperty
, which is available in the OWL serialization: https://github.com/geneontology/go-ontology/blob/master/contrib/oboInOwl#L474How can we keep the OBO file up to date with the OWL one?
The text was updated successfully, but these errors were encountered: