Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OBO in OWL #973

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Update OBO in OWL #973

merged 3 commits into from
Nov 16, 2023

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Nov 2, 2023

This PR updates the OBO in OWL record (see current record at https://bioregistry.io/oboinowl) in the following ways:

  1. Uses pseudo-PURLs for OBO and OWL download that correspond to the URIs
  2. Add @kltm as the contact person. There's still some ambiguity as to how this file is maintained, but since the URIs point to the GO repo, I think this is probably a good call for now
  3. Adds a loose pattern
  4. Adds additional examples

@matentzn @kltm I would love to have one of you contribute a more detailed description

See related recent discussions:

  1. OBO in OWL files are inconsistent geneontology/go-site#2157
  2. All synonym types defined as oboInOwl:SynonymType but historically they're defined as oboInOwl:SynonymTypeProperty information-artifact-ontology/ontology-metadata#157

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (04a19ae) 40.93% compared to head (ff6cad0) 40.93%.
Report is 1 commits behind head on main.

❗ Current head ff6cad0 differs from pull request most recent head 1a88bb0. Consider uploading reports for the commit 1a88bb0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #973   +/-   ##
=======================================
  Coverage   40.93%   40.93%           
=======================================
  Files         138      138           
  Lines        7905     7905           
  Branches     1841     1841           
=======================================
  Hits         3236     3236           
  Misses       4467     4467           
  Partials      202      202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kltm
Copy link

kltm commented Nov 3, 2023

I would defer to @cmungall and @balhoff here.

@cthoyt cthoyt merged commit c654398 into main Nov 16, 2023
11 checks passed
@cthoyt cthoyt deleted the update-oio branch November 16, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants